From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51094)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Tuovw-0003Q2-Pf
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 13:39:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Tuovp-0004Al-5x
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 13:38:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:6061)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Tuovo-0004Ah-UV
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 13:38:49 -0500
Date: Mon, 14 Jan 2013 16:38:51 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130114163851.1033ff3d@doriath.home>
In-Reply-To: <1358147387-8221-10-git-send-email-xiawenc@linux.vnet.ibm.com>
References: <1358147387-8221-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1358147387-8221-10-git-send-email-xiawenc@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V3 09/11] hmp: export function
	hmp_handle_error()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com

On Mon, 14 Jan 2013 15:09:45 +0800
Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:

> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>

This function is really a hmp.c-only helper. It does two more or less
unrelated things, I think it's better not to spread it over other
qemu source files.

> ---
>  hmp.c |    2 +-
>  hmp.h |    2 ++
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/hmp.c b/hmp.c
> index 2465d9b..89a1a8c 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -23,7 +23,7 @@
>  #include "monitor/monitor.h"
>  #include "ui/console.h"
>  
> -static void hmp_handle_error(Monitor *mon, Error **errp)
> +void hmp_handle_error(Monitor *mon, Error **errp)
>  {
>      if (error_is_set(errp)) {
>          monitor_printf(mon, "%s\n", error_get_pretty(*errp));
> diff --git a/hmp.h b/hmp.h
> index 5cab9c0..da1a35c 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -17,7 +17,9 @@
>  #include "qemu-common.h"
>  #include "qapi-types.h"
>  #include "qapi/qmp/qdict.h"
> +#include "qapi/error.h"
>  
> +void hmp_handle_error(Monitor *mon, Error **errp);
>  void hmp_info_name(Monitor *mon, const QDict *qdict);
>  void hmp_info_version(Monitor *mon, const QDict *qdict);
>  void hmp_info_kvm(Monitor *mon, const QDict *qdict);