From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TupEX-0004zp-Vw for qemu-devel@nongnu.org; Mon, 14 Jan 2013 13:58:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TupES-0000uB-2c for qemu-devel@nongnu.org; Mon, 14 Jan 2013 13:58:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TupER-0000u3-R8 for qemu-devel@nongnu.org; Mon, 14 Jan 2013 13:58:04 -0500 Date: Mon, 14 Jan 2013 16:58:07 -0200 From: Luiz Capitulino Message-ID: <20130114165807.1231b806@doriath.home> In-Reply-To: <1358147387-8221-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1358147387-8221-1-git-send-email-xiawenc@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 00/11] add qmp/hmp interfaces for snapshot info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: Kevin Wolf , aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com On Mon, 14 Jan 2013 15:09:36 +0800 Wenchao Xia wrote: > This serial of patches does two things: merge some info code > in qemu-img, and add following interfaces: > 1) qmp: query-images > 2) qmp: query-snapshots > 3) hmp: show snapshot info on a single block device > These patches follows the rule that use qmp to retieve information, > hmp layer just do a translation from qmp object it got, so almost > every hmp interface may have a correlated qmp interface. I've reviewed this and made some comments, and just to set expectations, I think this should go in through the block queue.