From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56318)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tv0rp-0006LH-Qj
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 02:23:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tv0ro-0006tr-Ln
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 02:23:29 -0500
Received: from mail-wi0-f171.google.com ([209.85.212.171]:55632)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tv0ro-0006tW-GX
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 02:23:28 -0500
Received: by mail-wi0-f171.google.com with SMTP id hn14so1976810wib.10
	for <qemu-devel@nongnu.org>; Mon, 14 Jan 2013 23:23:27 -0800 (PST)
Date: Tue, 15 Jan 2013 08:23:25 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130115072325.GB5649@stefanha-thinkpad.redhat.com>
References: <1358191213-404-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1358191213-404-3-git-send-email-mdroth@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1358191213-404-3-git-send-email-mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] dataplane: fix build breakage on
 set_guest_notifiers()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com

On Mon, Jan 14, 2013 at 01:20:13PM -0600, Michael Roth wrote:
> virtio_pci_set_guest_notifiers() now takes an additional argument to
> specify the number of virtqueues to assign a guest notifier for. This
> causes a build breakage for CONFIG_VIRTIO_BLK_DATA_PLANE builds:
> 
> /home/mdroth/w/qemu2.git/hw/dataplane/virtio-blk.c: In function
> ‘virtio_blk_data_plane_start’:
> /home/mdroth/w/qemu2.git/hw/dataplane/virtio-blk.c:451:47: error: too
> few arguments to function ‘s->vdev->binding->set_guest_notifiers’
> /home/mdroth/w/qemu2.git/hw/dataplane/virtio-blk.c: In function
> ‘virtio_blk_data_plane_stop’:
> /home/mdroth/w/qemu2.git/hw/dataplane/virtio-blk.c:511:5: error: too few
> arguments to function ‘s->vdev->binding->set_guest_notifiers’
> make[1]: *** [hw/dataplane/virtio-blk.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [subdir-x86_64-softmmu] Error 2
> 
> Fix this by passing 1 as the number of virtqueues to assign notifiers
> for.
> 
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
>  hw/dataplane/virtio-blk.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks for the fix, Mike!

Stefan