* [Qemu-devel] [PATCH] qcow2: Fix segfault on zero-length write
@ 2013-01-14 16:31 Kevin Wolf
2013-01-15 8:17 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2013-01-14 16:31 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, stefanha
One of the recent refactoring patches (commit f50f88b9) didn't take care
to initialise l2meta properly, so with zero-length writes, which don't
even enter the write loop, qemu just segfaulted.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow2.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 76c86a7..9c64917 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -759,7 +759,7 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState *bs,
QEMUIOVector hd_qiov;
uint64_t bytes_done = 0;
uint8_t *cluster_data = NULL;
- QCowL2Meta *l2meta;
+ QCowL2Meta *l2meta = NULL;
trace_qcow2_writev_start_req(qemu_coroutine_self(), sector_num,
remaining_sectors);
--
1.7.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Fix segfault on zero-length write
2013-01-14 16:31 [Qemu-devel] [PATCH] qcow2: Fix segfault on zero-length write Kevin Wolf
@ 2013-01-15 8:17 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2013-01-15 8:17 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, stefanha
On Mon, Jan 14, 2013 at 05:31:31PM +0100, Kevin Wolf wrote:
> One of the recent refactoring patches (commit f50f88b9) didn't take care
> to initialise l2meta properly, so with zero-length writes, which don't
> even enter the write loop, qemu just segfaulted.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-15 8:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-14 16:31 [Qemu-devel] [PATCH] qcow2: Fix segfault on zero-length write Kevin Wolf
2013-01-15 8:17 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).