From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv1hm-0001xk-69 for qemu-devel@nongnu.org; Tue, 15 Jan 2013 03:17:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tv1hh-0005eC-5F for qemu-devel@nongnu.org; Tue, 15 Jan 2013 03:17:10 -0500 Received: from mail-wg0-f43.google.com ([74.125.82.43]:48955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv1hg-0005dy-Ve for qemu-devel@nongnu.org; Tue, 15 Jan 2013 03:17:05 -0500 Received: by mail-wg0-f43.google.com with SMTP id e12so2636096wge.22 for ; Tue, 15 Jan 2013 00:17:04 -0800 (PST) Date: Tue, 15 Jan 2013 09:17:01 +0100 From: Stefan Hajnoczi Message-ID: <20130115081701.GA21625@stefanha-thinkpad.redhat.com> References: <1358181091-3857-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1358181091-3857-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qcow2: Fix segfault on zero-length write List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com On Mon, Jan 14, 2013 at 05:31:31PM +0100, Kevin Wolf wrote: > One of the recent refactoring patches (commit f50f88b9) didn't take care > to initialise l2meta properly, so with zero-length writes, which don't > even enter the write loop, qemu just segfaulted. > > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan