From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv9Na-00021K-Sp for qemu-devel@nongnu.org; Tue, 15 Jan 2013 11:28:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tv9NU-0007cp-Hk for qemu-devel@nongnu.org; Tue, 15 Jan 2013 11:28:50 -0500 Date: Tue, 15 Jan 2013 18:32:37 +0200 From: "Michael S. Tsirkin" Message-ID: <20130115163237.GA7997@redhat.com> References: <20130113104728.GA23188@redhat.com> <50F52AD2.6080400@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <50F52AD2.6080400@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL] pci,virtio List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: qemu-stable@nongnu.org, Alexander Graf , qemu-devel@nongnu.org, alex.williamson@redhat.com, Anthony Liguori , pbonzini@redhat.com On Tue, Jan 15, 2013 at 11:09:22AM +0100, Andreas F=E4rber wrote: > Am 13.01.2013 11:47, schrieb Michael S. Tsirkin: > > The following changes since commit 8e4a424b305e29dc0e454f52df3b35577f= 342975: > >=20 > > Revert "virtio-pci: replace byte swap hack" (2013-01-06 18:30:17 +0= 000) > >=20 > > are available in the git repository at: > >=20 > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony > >=20 > > for you to fetch changes up to feb9a2ab4b0260d8d680a7ffd25063dafc7ec6= 28: > >=20 > > pci-assign: Enable MSIX on device to match guest (2013-01-09 12:11:= 16 +0200) > >=20 > > ---------------------------------------------------------------- > > pci,virtio > >=20 > > This further optimizes MSIX handling in virtio-pci. > > Also included is pci cleanup by Paolo, and pci device > > assignment fix by Alex. > >=20 > > Signed-off-by: Michael S. Tsirkin > >=20 > > ---------------------------------------------------------------- > > Alex Williamson (1): > > pci-assign: Enable MSIX on device to match guest > >=20 > > Michael S. Tsirkin (8): > > virtio: don't waste irqfds on control vqs > > msix: add api to access msix message > > kvm: add stub for update msi route > > virtio-pci: cache msix messages >=20 > This broke the build with PowerKVM: >=20 > LINK ppc64-softmmu/qemu-system-ppc64 > ../hw/virtio-pci.o: In function `kvm_virtio_pci_vq_vector_unmask': > /home/andreas/QEMU/qemu/hw/virtio-pci.c:622: undefined reference to > `kvm_irqchip_update_msi_route' > collect2: error: ld returned 1 exit status > make[1]: *** [qemu-system-ppc64] Fehler 1 > make: *** [subdir-ppc64-softmmu] Fehler 2 >=20 > Can you supply a fix? It's not obvious to me how. >=20 > Thanks, > Andreas I'm not sure how to build this. Can you tell me pls? Maybe the below helps? kvm: add stub for kvm_irqchip_update_msi_route Signed-off-by: Michael S. Tsirkin diff --git a/kvm-all.c b/kvm-all.c index fc0c6e7..bac67da 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1182,6 +1182,11 @@ static int kvm_irqchip_assign_irqfd(KVMState *s, i= nt fd, int virq, bool assign) { abort(); } + +int kvm_irqchip_update_msi_route(KVMState *s, int virq, MSIMessage msg) +{ + return -ENOSYS; +} #endif /* !KVM_CAP_IRQ_ROUTING */ =20 int kvm_irqchip_add_irqfd_notifier(KVMState *s, EventNotifier *n, int vi= rq)