From: Igor Mammedov <imammedo@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH qom-cpu 1/2] target-i386/cpu.c: Coding style fixes
Date: Wed, 16 Jan 2013 08:34:14 +0100 [thread overview]
Message-ID: <20130116083414.3247dd17@thinkpad.mammed.net> (raw)
In-Reply-To: <1357870690-12680-2-git-send-email-ehabkost@redhat.com>
On Fri, 11 Jan 2013 00:18:09 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:
> * Add braces to 'if' statements;
> * Remove last TAB character from the source.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-By: Igor Mammedov <imammedo@redhat.com>
> ---
> target-i386/cpu.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 9a48e3f..0b44dea 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1917,12 +1917,13 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
> if (env->cpuid_ext2_features & CPUID_EXT2_LM) {
> /* 64 bit processor */
> /* XXX: The physical address space is limited to 42 bits in exec.c. */
> - *eax = 0x00003028; /* 48 bits virtual, 40 bits physical */
> + *eax = 0x00003028; /* 48 bits virtual, 40 bits physical */
> } else {
> - if (env->cpuid_features & CPUID_PSE36)
> + if (env->cpuid_features & CPUID_PSE36) {
> *eax = 0x00000024; /* 36 bits physical */
> - else
> + } else {
> *eax = 0x00000020; /* 32 bits physical */
> + }
> }
> *ebx = 0;
> *ecx = 0;
> --
> 1.7.11.7
>
--
Regards,
Igor
next prev parent reply other threads:[~2013-01-16 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 2:18 [Qemu-devel] [PATCH qom-cpu 0/2] replace cpuid_*features fields with a featue word array (v5) Eduardo Habkost
2013-01-11 2:18 ` [Qemu-devel] [PATCH qom-cpu 1/2] target-i386/cpu.c: Coding style fixes Eduardo Habkost
2013-01-16 7:34 ` Igor Mammedov [this message]
2013-01-11 2:18 ` [Qemu-devel] [PATCH qom-cpu 2/2] target-i386: Replace cpuid_*features fields with a feature word array Eduardo Habkost
2013-01-16 7:18 ` li guang
2013-01-17 14:57 ` [Qemu-devel] [PATCH 2/2 v6] " Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130116083414.3247dd17@thinkpad.mammed.net \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).