From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48234)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TvWCt-0007Qy-P0
	for qemu-devel@nongnu.org; Wed, 16 Jan 2013 11:51:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TvWCq-0005uw-GM
	for qemu-devel@nongnu.org; Wed, 16 Jan 2013 11:51:19 -0500
Received: from mx1.redhat.com ([209.132.183.28]:31119)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TvOmH-0008TS-Qq
	for qemu-devel@nongnu.org; Wed, 16 Jan 2013 03:55:21 -0500
Date: Wed, 16 Jan 2013 09:46:36 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130116084636.GA6693@stefanha-thinkpad.hitronhub.home>
References: <20130115174238.GA9798@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130115174238.GA9798@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-pci: fix irqfd cleanup argument
	order
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org

On Tue, Jan 15, 2013 at 07:42:38PM +0200, Michael S. Tsirkin wrote:
> Order of arguments of kvm_virtio_pci_irqfd_release
> got mixed up in all calls.
> As a result users see assertions during cleanup.
> 
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
>  hw/virtio-pci.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Thanks for the fix.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>