* [Qemu-devel] [Qemu-trivial] [PATCH] configure: silencing pkg-config's check for curses
@ 2013-01-15 23:52 Vadim Evard
2013-01-16 9:27 ` Stefan Hajnoczi
2013-01-16 14:54 ` Anthony Liguori
0 siblings, 2 replies; 5+ messages in thread
From: Vadim Evard @ 2013-01-15 23:52 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Anthony Liguori
>From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001
From: Vadim Evard <v.e.evard@gmail.com>
Date: Wed, 16 Jan 2013 03:45:44 +0400
Subject: [PATCH] configure: silencing pkg-config's check for curses
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 4ebb60d..6211db9 100755
--- a/configure
+++ b/configure
@@ -2039,7 +2039,7 @@ fi
if test "$mingw32" = "yes" ; then
curses_list="-lpdcurses"
else
- curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
+ curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
fi
if test "$curses" != "no" ; then
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: silencing pkg-config's check for curses
2013-01-15 23:52 [Qemu-devel] [Qemu-trivial] [PATCH] configure: silencing pkg-config's check for curses Vadim Evard
@ 2013-01-16 9:27 ` Stefan Hajnoczi
2013-01-16 14:54 ` Anthony Liguori
1 sibling, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2013-01-16 9:27 UTC (permalink / raw)
To: Vadim Evard; +Cc: qemu-trivial, Anthony Liguori, qemu-devel
On Wed, Jan 16, 2013 at 03:52:58AM +0400, Vadim Evard wrote:
> From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001
> From: Vadim Evard <v.e.evard@gmail.com>
> Date: Wed, 16 Jan 2013 03:45:44 +0400
> Subject: [PATCH] configure: silencing pkg-config's check for curses
>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Probably best if Anthony or another qemu.git committer applies this
straight away instead of waiting for the next qemu-trivial pull request.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: silencing pkg-config's check for curses
2013-01-15 23:52 [Qemu-devel] [Qemu-trivial] [PATCH] configure: silencing pkg-config's check for curses Vadim Evard
2013-01-16 9:27 ` Stefan Hajnoczi
@ 2013-01-16 14:54 ` Anthony Liguori
2013-01-16 20:17 ` [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence " Vadim Evard
1 sibling, 1 reply; 5+ messages in thread
From: Anthony Liguori @ 2013-01-16 14:54 UTC (permalink / raw)
To: Vadim Evard, qemu-devel; +Cc: qemu-trivial
Vadim Evard <v.e.evard@gmail.com> writes:
>>From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001
> From: Vadim Evard <v.e.evard@gmail.com>
> Date: Wed, 16 Jan 2013 03:45:44 +0400
> Subject: [PATCH] configure: silencing pkg-config's check for curses
This is fubar above and it's missing a Signed-off-by. Please CC me when
you send out a new version that fixes this.
Regards,
Anthony Liguori
>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4ebb60d..6211db9 100755
> --- a/configure
> +++ b/configure
> @@ -2039,7 +2039,7 @@ fi
> if test "$mingw32" = "yes" ; then
> curses_list="-lpdcurses"
> else
> - curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
> + curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
> fi
>
> if test "$curses" != "no" ; then
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses
2013-01-16 14:54 ` Anthony Liguori
@ 2013-01-16 20:17 ` Vadim Evard
2013-01-17 20:01 ` Anthony Liguori
0 siblings, 1 reply; 5+ messages in thread
From: Vadim Evard @ 2013-01-16 20:17 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Anthony Liguori
Signed-off-by: Vadim Evard <v.e.evard@gmail.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 4ebb60d..6211db9 100755
--- a/configure
+++ b/configure
@@ -2039,7 +2039,7 @@ fi
if test "$mingw32" = "yes" ; then
curses_list="-lpdcurses"
else
- curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
+ curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
fi
if test "$curses" != "no" ; then
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses
2013-01-16 20:17 ` [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence " Vadim Evard
@ 2013-01-17 20:01 ` Anthony Liguori
0 siblings, 0 replies; 5+ messages in thread
From: Anthony Liguori @ 2013-01-17 20:01 UTC (permalink / raw)
To: Vadim Evard, qemu-devel; +Cc: qemu-trivial
Vadim Evard <v.e.evard@gmail.com> writes:
> Signed-off-by: Vadim Evard <v.e.evard@gmail.com>
Please post this as a top-level patch. (no in-reply-to)
Regards,
Anthony Liguori
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4ebb60d..6211db9 100755
> --- a/configure
> +++ b/configure
> @@ -2039,7 +2039,7 @@ fi
> if test "$mingw32" = "yes" ; then
> curses_list="-lpdcurses"
> else
> - curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
> + curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
> fi
>
> if test "$curses" != "no" ; then
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-17 20:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-15 23:52 [Qemu-devel] [Qemu-trivial] [PATCH] configure: silencing pkg-config's check for curses Vadim Evard
2013-01-16 9:27 ` Stefan Hajnoczi
2013-01-16 14:54 ` Anthony Liguori
2013-01-16 20:17 ` [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence " Vadim Evard
2013-01-17 20:01 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).