From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvT3n-0004Kq-TF for qemu-devel@nongnu.org; Wed, 16 Jan 2013 08:29:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvT3m-0001NI-Up for qemu-devel@nongnu.org; Wed, 16 Jan 2013 08:29:43 -0500 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:55306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvT3m-0001N6-Og for qemu-devel@nongnu.org; Wed, 16 Jan 2013 08:29:42 -0500 Received: by mail-wg0-f42.google.com with SMTP id dr1so2675068wgb.3 for ; Wed, 16 Jan 2013 05:29:41 -0800 (PST) Date: Wed, 16 Jan 2013 14:29:39 +0100 From: Stefan Hajnoczi Message-ID: <20130116132939.GA9277@stefanha-thinkpad.redhat.com> References: <20130116114521.GA20630@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130116114521.GA20630@redhat.com> Subject: Re: [Qemu-devel] [PATCH] virtio-net: revert mac on reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , Anthony Liguori , Laszlo Ersek , qemu-devel@nongnu.org On Wed, Jan 16, 2013 at 01:45:21PM +0200, Michael S. Tsirkin wrote: > Once guest overrides virtio net primary mac, > it retains the value set until qemu exit. > This is inconsistent with standard nic behaviour. > To fix, revert the mac to the original value on reset. > > Signed-off-by: Michael S. Tsirkin > --- > hw/virtio-net.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Stefan Hajnoczi