From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52876)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TvUr8-0001Ks-VL
	for qemu-devel@nongnu.org; Wed, 16 Jan 2013 10:24:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TvUr2-0006UT-1u
	for qemu-devel@nongnu.org; Wed, 16 Jan 2013 10:24:46 -0500
Received: from mail-wg0-f51.google.com ([74.125.82.51]:46795)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TvUr1-0006UN-RR
	for qemu-devel@nongnu.org; Wed, 16 Jan 2013 10:24:39 -0500
Received: by mail-wg0-f51.google.com with SMTP id gg4so925226wgb.18
	for <qemu-devel@nongnu.org>; Wed, 16 Jan 2013 07:24:39 -0800 (PST)
Date: Wed, 16 Jan 2013 16:24:36 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130116152436.GD9679@stefanha-thinkpad.redhat.com>
References: <1358006986-7248-1-git-send-email-dmitry@daynix.com>
	<1358006986-7248-4-git-send-email-dmitry@daynix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1358006986-7248-4-git-send-email-dmitry@daynix.com>
Subject: Re: [Qemu-devel] [PATCH v9 3/5] Adding common definitions for
 VMWARE devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Yan Vugenfirer <yan@daynix.com>, Gerhard Wiesinger <lists@wiesinger.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>

On Sat, Jan 12, 2013 at 06:09:44PM +0200, Dmitry Fleytman wrote:
> diff --git a/eth.c b/eth.c
> new file mode 100644
> index 0000000..a591ee5
> --- /dev/null
> +++ b/eth.c
> @@ -0,0 +1,219 @@
> +/*
> + * QEMU network structures definitions and helper functions
> + *
> + * Copyright (c) 2012 Ravello Systems LTD (http://ravellosystems.com)
> + *
> + * Developed by Daynix Computing LTD (http://www.daynix.com)
> + *
> + * Authors:
> + * Dmitry Fleytman <dmitry@daynix.com>
> + * Tamir Shomer <tamirs@daynix.com>
> + * Yan Vugenfirer <yan@daynix.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + *
> + */
> +
> +//#include "hw.h"

Please remove this commented-out line.

> diff --git a/include/qemu/eth.h b/include/qemu/eth.h
> new file mode 100644
> index 0000000..b806fb4
> --- /dev/null
> +++ b/include/qemu/eth.h
> @@ -0,0 +1,338 @@
> +/*
> + * QEMU network structures definitions and helper functions
> + *
> + * Copyright (c) 2012 Ravello Systems LTD (http://ravellosystems.com)
> + *
> + * Developed by Daynix Computing LTD (http://www.daynix.com)
> + *
> + * Authors:
> + * Dmitry Fleytman <dmitry@daynix.com>
> + * Tamir Shomer <tamirs@daynix.com>
> + * Yan Vugenfirer <yan@daynix.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + *
> + */

Please indicate where these header definitions come from and how they
are licensed.