From: David Gibson <david@gibson.dropbear.id.au>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] bswap: improve gluing
Date: Thu, 17 Jan 2013 12:11:22 +1100 [thread overview]
Message-ID: <20130117011122.GB26321@truffula.fritz.box> (raw)
In-Reply-To: <1309ac93ff943931eb213dd87cd3570910b23926.1358094930.git.blauwirbel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
On Sun, Jan 13, 2013 at 04:35:41PM +0000, Blue Swirl wrote:
> OpenBSD system compiler (gcc 4.2.1) has problems with concatenation
> of macro arguments in macro functions:
> CC aes.o
> In file included from /src/qemu/include/qemu-common.h:126,
> from /src/qemu/aes.c:30:
> /src/qemu/include/qemu/bswap.h: In function 'leul_to_cpu':
> /src/qemu/include/qemu/bswap.h:461: warning: implicit declaration of function 'bswapHOST_LONG_BITS'
> /src/qemu/include/qemu/bswap.h:461: warning: nested extern declaration of 'bswapHOST_LONG_BITS'
>
> Function leul_to_cpu() is only used in kvm-all.c, so the warnings
> are not fatal on OpenBSD without -Werror.
>
> Fix by applying glue(). Also add do {} while(0) wrapping and fix
> semicolon use while at it.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
In fact, this is not merely an improvement, and not OpenBSD specific.
This is a vital bugfix for all big-endian hosts.
Please apply.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-01-17 1:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-13 16:35 [Qemu-devel] [PATCH] bswap: improve gluing Blue Swirl
2013-01-14 15:15 ` Richard Henderson
2013-01-15 4:25 ` Andreas Färber
2013-01-17 1:11 ` David Gibson [this message]
2013-01-17 7:50 ` Markus Armbruster
2013-01-18 16:31 ` Alexander Graf
2013-01-18 17:03 ` Markus Armbruster
2013-01-20 20:53 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117011122.GB26321@truffula.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).