From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvmDC-0002Uw-Ti for qemu-devel@nongnu.org; Thu, 17 Jan 2013 04:56:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvmD9-00070N-15 for qemu-devel@nongnu.org; Thu, 17 Jan 2013 04:56:42 -0500 Date: Thu, 17 Jan 2013 10:56:36 +0100 From: Stefan Hajnoczi Message-ID: <20130117095636.GA27018@stefanha-thinkpad.redhat.com> References: <1358360751-1745-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1358360751-1745-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] aio-posix: Fix return value of aio_poll() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org On Wed, Jan 16, 2013 at 07:25:51PM +0100, Kevin Wolf wrote: > aio_poll() must return true if any work is still pending, even if it > didn't make progress, so that bdrv_drain_all() doesn't stop waiting too > early. The possibility of stopping early occasionally lead to a failed > assertion in bdrv_drain_all(), when some in-flight request was missed > and the function didn't really drain all requests. > > In order to make that change, the return value as specified in the > function comment must change for blocking = false; fortunately, the > return value of blocking = false callers is only used in test cases, so > this change shouldn't cause any trouble. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Kevin Wolf > --- > aio-posix.c | 3 ++- > aio-win32.c | 3 ++- > include/block/aio.h | 6 ++---- > tests/test-aio.c | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) Changed "aio-posix" to "aio" in commit message. Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan