From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39793)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tvmdx-0007yb-Um
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 05:24:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tvmdu-0006XP-VS
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 05:24:21 -0500
Received: from mail-wg0-f47.google.com ([74.125.82.47]:58390)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tvmdu-0006XI-Ot
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 05:24:18 -0500
Received: by mail-wg0-f47.google.com with SMTP id dq11so1547196wgb.14
	for <qemu-devel@nongnu.org>; Thu, 17 Jan 2013 02:24:18 -0800 (PST)
Date: Thu, 17 Jan 2013 11:24:15 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130117102415.GC2586@stefanha-thinkpad.redhat.com>
References: <1358006986-7248-1-git-send-email-dmitry@daynix.com>
	<1358006986-7248-5-git-send-email-dmitry@daynix.com>
	<20130116144800.GB9679@stefanha-thinkpad.redhat.com>
	<50F6C85C.5020109@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50F6C85C.5020109@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 4/5] Adding packet abstraction for
 VMWARE network devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>, Yan Vugenfirer <yan@daynix.com>, Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org, Gerhard Wiesinger <lists@wiesinger.com>

On Wed, Jan 16, 2013 at 04:33:48PM +0100, Paolo Bonzini wrote:
> Il 16/01/2013 15:48, Stefan Hajnoczi ha scritto:
> >> >  hw/vmxnet_rx_pkt.c | 187 ++++++++++++++++++
> >> >  hw/vmxnet_rx_pkt.h | 173 ++++++++++++++++
> >> >  hw/vmxnet_tx_pkt.c | 567 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >> >  hw/vmxnet_tx_pkt.h | 148 ++++++++++++++
> >> >  4 files changed, 1075 insertions(+)
> >> >  create mode 100644 hw/vmxnet_rx_pkt.c
> >> >  create mode 100644 hw/vmxnet_rx_pkt.h
> >> >  create mode 100644 hw/vmxnet_tx_pkt.c
> >> >  create mode 100644 hw/vmxnet_tx_pkt.h
> > There are other VMware-specific hw/ files.  Please create hw/vmware/ and
> > put source files in there without the prefix.  Check hw/pci/ or other
> > subdirectories for how to setup Makefile.objs, it's pretty simple.
> 
> I don't think we have enough plans for hw/ structure to create
> directories yet.  What we have so far is basically hw/<arch> and
> hw/<bus>, so the logic would be to have hw/net (also mimicking Linux's
> drivers/net directory).  It's premature to create hw/vmware, we risk
> getting a spaghetti directory structure.

Okay, let's leave the hw/ sub-directory for a future hw/-wide cleanup
series that moves all device emulation code.

> eth.c/eth.h sound more interesting.  Could they be used by host-side
> code (e.g. SLIRP or a TAP backend)?  If so, they belong in net/ and
> include/net.  If not, they belong in hw/ (waiting for hw/net to be created).

Yes, they can be used by host (backend) code.

Stefan