From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47114)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TvpAb-0002ht-73
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 08:06:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TvpAZ-0003iK-Jg
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 08:06:13 -0500
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:52440)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tvmfl-000772-T4
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 05:26:14 -0500
Received: by mail-wg0-f42.google.com with SMTP id dr1so3324966wgb.5
	for <qemu-devel@nongnu.org>; Thu, 17 Jan 2013 02:26:12 -0800 (PST)
Date: Thu, 17 Jan 2013 11:26:10 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130117102610.GD2586@stefanha-thinkpad.redhat.com>
References: <1358236046-17242-1-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1358236046-17242-1-git-send-email-stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Makefile: drop recursive libcacard clean
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Tue, Jan 15, 2013 at 08:47:26AM +0100, Stefan Hajnoczi wrote:
> Commit eb8eb53e5846a957cf333f2e1ec8cb6e0c04 ("libcacard: rewrite
> Makefile in non-recursive style") refactored libcacard/Makefile so it
> can be included by the top-level Makefile.
> 
> The top-level clean target still loops over subdirectories, including
> libcacard/, to invoke recursive clean.  Remove libcacard from the
> recursive clean since its files are already included at the top level.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 7622a4c..0ecfcda 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -226,7 +226,7 @@ clean:
>  	rm -rf qapi-generated
>  	rm -rf qga/qapi-generated
>  	$(MAKE) -C tests/tcg clean
> -	for d in $(ALL_SUBDIRS) libcacard; do \
> +	for d in $(ALL_SUBDIRS); do \
>  	if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \
>  	rm -f $$d/qemu-options.def; \
>          done

Ping.  Please apply so that make clean succeeds.

Stefan