qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] rules/mak: make clean should blow away timestamp files
Date: Thu, 17 Jan 2013 11:28:46 +0100	[thread overview]
Message-ID: <20130117102846.GE2586@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <d6a80c4d4cfb62bfa99b37d0acd466d7ed77c53b.1358267772.git.mst@redhat.com>

On Tue, Jan 15, 2013 at 06:57:34PM +0200, Michael S. Tsirkin wrote:
> Using a global pattern makes it easier to clean out
> old generated files.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  rules.mak | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/rules.mak b/rules.mak
> index d11a5b4..edc2552 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -88,6 +88,11 @@ config-%.h: config-%.h-timestamp
>  config-%.h-timestamp: config-%.mak
>  	$(call quiet-command, sh $(SRC_PATH)/scripts/create_config < $< > $@, "  GEN   $(TARGET_DIR)config-$*.h")
>  
> +.PHONY: clean-timestamp
> +clean-timestamp:
> +	rm -f *.timestamp

Timestamp files also live in subdirectories and I think we're slowly
moving away from recursive make, so this may not clean all timestamp
files.

Stefan

  reply	other threads:[~2013-01-17 11:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15 16:36 [Qemu-devel] [PATCH 0/4] qemu timestamp and related makefile cleanups Michael S. Tsirkin
2013-01-15 16:36 ` [Qemu-devel] [PATCH 1/4] rules.mak: cleanup config generation rules Michael S. Tsirkin
2013-01-15 16:36 ` [Qemu-devel] [PATCH 4/4] Makefile: fix make clean on libcacard Michael S. Tsirkin
2013-01-17 10:33   ` Stefan Hajnoczi
2013-01-17 10:50     ` Michael S. Tsirkin
2013-01-18 13:28       ` Stefan Hajnoczi
2013-01-15 16:36 ` [Qemu-devel] [PATCH 3/4] rules/mak: make clean should blow away timestamp files Michael S. Tsirkin
2013-01-17 10:28   ` Stefan Hajnoczi [this message]
2013-01-17 10:48     ` Michael S. Tsirkin
2013-01-18 13:27       ` Stefan Hajnoczi
2013-01-15 16:36 ` [Qemu-devel] [PATCH 2/4] Makefile: clean timestamp generation rule Michael S. Tsirkin
2013-01-17 10:31   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130117102846.GE2586@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).