From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42401)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TvmzO-0007cw-Iz
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 05:46:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TvmzB-0002q9-S8
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 05:46:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48901)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TvmzB-0002q2-K8
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 05:46:17 -0500
Date: Thu, 17 Jan 2013 12:50:18 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130117105017.GB15393@redhat.com>
References: <cover.1358267772.git.mst@redhat.com>
	<87539969776f984e4b50736ba13c15f8131e6b2f.1358267772.git.mst@redhat.com>
	<20130117103303.GG2586@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130117103303.GG2586@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] Makefile: fix make clean on libcacard
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org

On Thu, Jan 17, 2013 at 11:33:03AM +0100, Stefan Hajnoczi wrote:
> On Tue, Jan 15, 2013 at 06:36:50PM +0200, Michael S. Tsirkin wrote:
> > libcacard lacks a clean target. Need to fix it,
> > meanwhile mark this target phony so it does not
> > stop parallel make clean.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  libcacard/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libcacard/Makefile b/libcacard/Makefile
> > index 47827a0..a3518c1 100644
> > --- a/libcacard/Makefile
> > +++ b/libcacard/Makefile
> > @@ -35,7 +35,7 @@ libcacard.pc: $(SRC_PATH)/libcacard/libcacard.pc.in
> >  		-e 's|@PREFIX@|$(prefix)|' $< > libcacard.pc,\
> >  	"  GEN   $@")
> >  
> > -.PHONY: install-libcacard
> > +.PHONY: install-libcacard clean
> 
> libcacard/Makefile is not supposed to have a clean target since
> 992aeb8eb53e5846a957cf333f2e1ec8cb6e0c04 ("libcacard: rewrite Makefile
> in non-recursive style").
> 
> I have a patch on qemu-devel to remove libcacard from the make clean
> loop since its objects are already handled by the global clean now that
> the file is sourced rather than invoked recursively.
> 
> Stefan

That will help too. Can you give me the msg id? Maybe I'll just
put it on my tree.

-- 
MST