From: Stefan Hajnoczi <stefanha@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename()
Date: Thu, 17 Jan 2013 12:24:20 +0100 [thread overview]
Message-ID: <20130117112420.GJ2586@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1358357540-29862-9-git-send-email-armbru@redhat.com>
On Wed, Jan 16, 2013 at 06:32:17PM +0100, Markus Armbruster wrote:
> diff --git a/qemu-log.c b/qemu-log.c
> index 64a1b88..30c8b01 100644
> --- a/qemu-log.c
> +++ b/qemu-log.c
> @@ -21,10 +21,12 @@
> #include "qemu/log.h"
>
> #ifdef WIN32
> -static const char *logfilename = "qemu.log";
> +#define DEFAULT_LOGFILENAME "qemu.log"
> #else
> -static const char *logfilename = "/tmp/qemu.log";
> +#define DEFAULT_LOGFILENAME "/tmp/qemu.log"
> #endif
> +
> +static const char *logfilename;
[...]
> @@ -84,6 +88,7 @@ void qemu_set_log(int log_flags, bool use_own_buffers)
>
> void cpu_set_log_filename(const char *filename)
> {
> + g_free((void *)logfilename);
Might as well drop the const from the variable declaration to indicate
that we allocate/free this string.
Stefan
next prev parent reply other threads:[~2013-01-17 11:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 17:32 [Qemu-devel] Trivial memory allocation fixes & cleanups Markus Armbruster
2013-01-16 17:32 ` [Qemu-devel] [PATCH v2 01/11] g_malloc(0) and g_malloc0(0) return NULL; simplify Markus Armbruster
2013-01-16 17:32 ` [Qemu-devel] [PATCH v2 02/11] g_strdup(NULL) returns " Markus Armbruster
2013-01-16 17:32 ` [Qemu-devel] [PATCH v2 03/11] hw/9pfs: Fix unchecked strdup() by converting to g_strdup() Markus Armbruster
2013-01-17 11:19 ` Stefan Hajnoczi
2013-01-17 13:21 ` Markus Armbruster
2013-01-16 17:32 ` [Qemu-devel] [PATCH v2 04/11] readline: " Markus Armbruster
2013-01-16 17:32 ` [Qemu-devel] [PATCH v2 05/11] spice: " Markus Armbruster
2013-01-16 17:32 ` [Qemu-devel] [PATCH v2 06/11] virtfs-proxy-helper: Fix unchecked strdup() by conv. " Markus Armbruster
2013-01-17 11:22 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2013-01-17 13:10 ` Markus Armbruster
2013-01-16 17:32 ` [Qemu-devel] [PATCH v2 07/11] qemu-log: Fix unchecked strdup() by converting " Markus Armbruster
2013-01-16 17:32 ` [Qemu-devel] [PATCH v2 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename() Markus Armbruster
2013-01-16 18:10 ` Eric Blake
2013-01-17 11:24 ` Stefan Hajnoczi [this message]
2013-01-17 13:17 ` [Qemu-devel] [Qemu-trivial] " Markus Armbruster
2013-01-16 17:32 ` [Qemu-devel] [PATCH v2 09/11] libcacard: Fix unchecked strdup() by converting to g_strdup() Markus Armbruster
2013-01-16 17:32 ` [Qemu-devel] [PATCH v2 10/11] qapi: " Markus Armbruster
2013-01-16 17:32 ` [Qemu-devel] [PATCH v2 11/11] qemu-ga: " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117112420.GJ2586@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).