From: Stefan Hajnoczi <stefanha@redhat.com>
To: akong@redhat.com
Cc: rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org,
qemu-devel@nongnu.org, kvm@vger.kernel.org, mst@redhat.com
Subject: Re: [Qemu-devel] [QEMU PATCH v3] virtio-net: introduce a new macaddr control
Date: Thu, 17 Jan 2013 13:40:18 +0100 [thread overview]
Message-ID: <20130117124018.GA6830@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1358418646-29626-1-git-send-email-akong@redhat.com>
On Thu, Jan 17, 2013 at 06:30:46PM +0800, akong@redhat.com wrote:
> From: Amos Kong <akong@redhat.com>
>
> In virtio-net guest driver, currently we write MAC address to
> pci config space byte by byte, this means that we have an
> intermediate step where mac is wrong. This patch introduced
> a new control command to set MAC address, it's atomic.
>
> VIRTIO_NET_F_CTRL_MAC_ADDR is a new feature bit for compatibility.
>
> "mac" field will be set to read-only when VIRTIO_NET_F_CTRL_MAC_ADDR
> is acked.
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> V2: check guest's iov_len
> V3: fix of migration compatibility
> make mac field in config space read-only when new feature is acked
> ---
> hw/pc_piix.c | 4 ++++
> hw/virtio-net.c | 10 +++++++++-
> hw/virtio-net.h | 12 ++++++++++--
> 3 files changed, 23 insertions(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
prev parent reply other threads:[~2013-01-17 12:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 10:30 [Qemu-devel] [QEMU PATCH v3] virtio-net: introduce a new macaddr control akong
2013-01-17 12:40 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117124018.GA6830@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=akong@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).