From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49970)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1TvpKl-0007Sv-2M
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 08:16:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1TvpKk-0006X6-29
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 08:16:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43890)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1TvpKj-0006Wr-QX
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 08:16:41 -0500
Date: Thu, 17 Jan 2013 15:16:37 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20130117131637.GD31120@redhat.com>
References: <1358344229-18006-1-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1358344229-18006-1-git-send-email-armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/8] Fixes and cleanups around fw_cfg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: blauwirbel@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org

On Wed, Jan 16, 2013 at 02:50:21PM +0100, Markus Armbruster wrote:
> Markus Armbruster (8):
>   fw_cfg: Replace debug prints by tracepoints
>   fw_cfg: Dumb down fw_cfg_add_*() not to return success / failure
>   fw_cfg: New fw_cfg_add_string()
>   pc: Fix unchecked strdup() by switching to fw_cfg_add_string()
>   sun4: Fix unchecked strdup() by switching to fw_cfg_add_string()
>   pc: Clean up bochs_bios_init()'s (non-)use of sizeof
>   fw_cfg: Use void *, size_t instead of uint8_t *, uint32_t for blobs
>   vl: Use size_t for sizes in get_boot_devices_list()
> 
Reviewed-by: Gleb Natapov <gleb@redhat.com>

>  hw/fw_cfg.c             | 86 ++++++++++++++++++++-----------------------------
>  hw/fw_cfg.h             | 17 +++++-----
>  hw/pc.c                 | 21 ++++++------
>  hw/sun4m.c              | 12 ++-----
>  hw/sun4u.c              |  4 +--
>  include/sysemu/sysemu.h |  2 +-
>  trace-events            |  7 ++++
>  vl.c                    |  6 ++--
>  8 files changed, 68 insertions(+), 87 deletions(-)
> 
> -- 
> 1.7.11.7

--
			Gleb.