From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58507)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TwByf-0003xi-1m
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 08:27:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TwByd-0001AH-Tt
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 08:27:24 -0500
Received: from mail-bk0-f48.google.com ([209.85.214.48]:35692)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TwByd-0001AC-N7
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 08:27:23 -0500
Received: by mail-bk0-f48.google.com with SMTP id jc3so1961766bkc.7
	for <qemu-devel@nongnu.org>; Fri, 18 Jan 2013 05:27:22 -0800 (PST)
Date: Fri, 18 Jan 2013 14:27:19 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130118132719.GB23240@stefanha-thinkpad.redhat.com>
References: <cover.1358267772.git.mst@redhat.com>
	<d6a80c4d4cfb62bfa99b37d0acd466d7ed77c53b.1358267772.git.mst@redhat.com>
	<20130117102846.GE2586@stefanha-thinkpad.redhat.com>
	<20130117104850.GA15393@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130117104850.GA15393@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] rules/mak: make clean should blow away
 timestamp files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, Jan 17, 2013 at 12:48:51PM +0200, Michael S. Tsirkin wrote:
> On Thu, Jan 17, 2013 at 11:28:46AM +0100, Stefan Hajnoczi wrote:
> > On Tue, Jan 15, 2013 at 06:57:34PM +0200, Michael S. Tsirkin wrote:
> > > Using a global pattern makes it easier to clean out
> > > old generated files.
> > > 
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > ---
> > >  rules.mak | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/rules.mak b/rules.mak
> > > index d11a5b4..edc2552 100644
> > > --- a/rules.mak
> > > +++ b/rules.mak
> > > @@ -88,6 +88,11 @@ config-%.h: config-%.h-timestamp
> > >  config-%.h-timestamp: config-%.mak
> > >  	$(call quiet-command, sh $(SRC_PATH)/scripts/create_config < $< > $@, "  GEN   $(TARGET_DIR)config-$*.h")
> > >  
> > > +.PHONY: clean-timestamp
> > > +clean-timestamp:
> > > +	rm -f *.timestamp
> > 
> > Timestamp files also live in subdirectories and I think we're slowly
> > moving away from recursive make, so this may not clean all timestamp
> > files.
> > 
> > Stefan
> 
> Yes but it helps whenever we include rules.mak which is in most places.

Okay, something to keep an eye on when Makefiles are converted to
non-recursive.

Stefan