Re: [Qemu-devel] [PATCH 4/4] Makefile: fix make clean on libcacard

[Stefan Hajnoczi <stefanha@gmail.com>]

On Thu, Jan 17, 2013 at 12:50:18PM +0200, Michael S. Tsirkin wrote:
> On Thu, Jan 17, 2013 at 11:33:03AM +0100, Stefan Hajnoczi wrote:
> > On Tue, Jan 15, 2013 at 06:36:50PM +0200, Michael S. Tsirkin wrote:
> > > libcacard lacks a clean target. Need to fix it,
> > > meanwhile mark this target phony so it does not
> > > stop parallel make clean.
> > > 
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > ---
> > >  libcacard/Makefile | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/libcacard/Makefile b/libcacard/Makefile
> > > index 47827a0..a3518c1 100644
> > > --- a/libcacard/Makefile
> > > +++ b/libcacard/Makefile
> > > @@ -35,7 +35,7 @@ libcacard.pc: $(SRC_PATH)/libcacard/libcacard.pc.in
> > >  		-e 's|@PREFIX@|$(prefix)|' $< > libcacard.pc,\
> > >  	"  GEN   $@")
> > >  
> > > -.PHONY: install-libcacard
> > > +.PHONY: install-libcacard clean
> > 
> > libcacard/Makefile is not supposed to have a clean target since
> > 992aeb8eb53e5846a957cf333f2e1ec8cb6e0c04 ("libcacard: rewrite Makefile
> > in non-recursive style").
> > 
> > I have a patch on qemu-devel to remove libcacard from the make clean
> > loop since its objects are already handled by the global clean now that
> > the file is sourced rather than invoked recursively.
> > 
> > Stefan
> 
> That will help too. Can you give me the msg id? Maybe I'll just
> put it on my tree.

<1358236046-17242-1-git-send-email-stefanha@redhat.com>

Stefan