From: Stefan Hajnoczi <stefanha@gmail.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, TeLeMan <geleman@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Trivial PATCH] acpitable: open the data file in binary mode
Date: Fri, 18 Jan 2013 14:44:02 +0100 [thread overview]
Message-ID: <20130118134402.GC24367@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1358420032-25275-1-git-send-email-mjt@msgid.tls.msk.ru>
On Thu, Jan 17, 2013 at 02:53:52PM +0400, Michael Tokarev wrote:
> -acpitable {file|data}=file reads the content of file, but it is
> in binary form, so the file should be opened usin O_BINARY flag.
> On *nix it is a no-op, but on windows and other weird platform
> it is really needed.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> hw/acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
prev parent reply other threads:[~2013-01-18 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 10:53 [Qemu-devel] [Trivial PATCH] acpitable: open the data file in binary mode Michael Tokarev
2013-01-18 13:44 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118134402.GC24367@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=geleman@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).