* [Qemu-devel] [Trivial PATCH] acpitable: open the data file in binary mode
@ 2013-01-17 10:53 Michael Tokarev
2013-01-18 13:44 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Michael Tokarev @ 2013-01-17 10:53 UTC (permalink / raw)
To: qemu-trivial; +Cc: TeLeMan, Michael Tokarev, qemu-devel
-acpitable {file|data}=file reads the content of file, but it is
in binary form, so the file should be opened usin O_BINARY flag.
On *nix it is a no-op, but on windows and other weird platform
it is really needed.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
hw/acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi.c b/hw/acpi.c
index 5d521e5..49510be 100644
--- a/hw/acpi.c
+++ b/hw/acpi.c
@@ -115,7 +115,7 @@ int acpi_table_add(const char *t)
/* now read in the data files, reallocating buffer as needed */
for (f = strtok(buf, ":"); f; f = strtok(NULL, ":")) {
- int fd = open(f, O_RDONLY);
+ int fd = open(f, O_RDONLY | O_BINARY);
if (fd < 0) {
fprintf(stderr, "can't open file %s: %s\n", f, strerror(errno));
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [Trivial PATCH] acpitable: open the data file in binary mode
2013-01-17 10:53 [Qemu-devel] [Trivial PATCH] acpitable: open the data file in binary mode Michael Tokarev
@ 2013-01-18 13:44 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2013-01-18 13:44 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, TeLeMan, qemu-devel
On Thu, Jan 17, 2013 at 02:53:52PM +0400, Michael Tokarev wrote:
> -acpitable {file|data}=file reads the content of file, but it is
> in binary form, so the file should be opened usin O_BINARY flag.
> On *nix it is a no-op, but on windows and other weird platform
> it is really needed.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> hw/acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-18 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-17 10:53 [Qemu-devel] [Trivial PATCH] acpitable: open the data file in binary mode Michael Tokarev
2013-01-18 13:44 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).