From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwCF2-0005k0-CM for qemu-devel@nongnu.org; Fri, 18 Jan 2013 08:44:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwCEx-0004zR-JW for qemu-devel@nongnu.org; Fri, 18 Jan 2013 08:44:20 -0500 Date: Fri, 18 Jan 2013 14:44:02 +0100 From: Stefan Hajnoczi Message-ID: <20130118134402.GC24367@stefanha-thinkpad.redhat.com> References: <1358420032-25275-1-git-send-email-mjt@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1358420032-25275-1-git-send-email-mjt@msgid.tls.msk.ru> Subject: Re: [Qemu-devel] [Trivial PATCH] acpitable: open the data file in binary mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, TeLeMan , qemu-devel@nongnu.org On Thu, Jan 17, 2013 at 02:53:52PM +0400, Michael Tokarev wrote: > -acpitable {file|data}=file reads the content of file, but it is > in binary form, so the file should be opened usin O_BINARY flag. > On *nix it is a no-op, but on windows and other weird platform > it is really needed. > > Signed-off-by: Michael Tokarev > --- > hw/acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan