Re: [Qemu-devel] [PATCH] qemu-pixman.h: Avoid mutual inclusion loop with console.h

[Stefan Hajnoczi <stefanha@gmail.com>]

On Thu, Jan 17, 2013 at 03:52:08PM +0000, Peter Maydell wrote:
> Remove an unnecessary mutual inclusion loop between qemu-pixman.h and
> console.h, since the former was only including the latter for
> 'PixelFormat*', which can be provided by typedefs.h.  This requires a
> minor adjustment to qemu-pixman.c, which was relying on the implicit
> inclusion of console.h for the actual struct PixelFormat definition,
> and on implicitly dragging in a header defining NULL.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I noticed this because I had an out of tree file which included
> ui/console.h before qemu-common.h and it didn't compile. But mutual
> include loops are a bad idea anyway IMHO.
> 
>  include/ui/qemu-pixman.h |    2 +-
>  ui/qemu-pixman.c         |    3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)

CC    ui/curses.o
In file included from ui/spice-core.c:40:0:
/home/stefanha/qemu/include/ui/spice-display.h:93:5: error: unknown type name ‘QEMUCursor’

Stefan