From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwCHz-0006fC-Du for qemu-devel@nongnu.org; Fri, 18 Jan 2013 08:47:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwCHy-0005fI-5p for qemu-devel@nongnu.org; Fri, 18 Jan 2013 08:47:23 -0500 Date: Fri, 18 Jan 2013 14:47:16 +0100 From: Stefan Hajnoczi Message-ID: <20130118134716.GD24367@stefanha-thinkpad.redhat.com> References: <1358437928-2420-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1358437928-2420-1-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [PATCH] qemu-pixman.h: Avoid mutual inclusion loop with console.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, Paolo Bonzini , qemu-devel@nongnu.org, patches@linaro.org On Thu, Jan 17, 2013 at 03:52:08PM +0000, Peter Maydell wrote: > Remove an unnecessary mutual inclusion loop between qemu-pixman.h and > console.h, since the former was only including the latter for > 'PixelFormat*', which can be provided by typedefs.h. This requires a > minor adjustment to qemu-pixman.c, which was relying on the implicit > inclusion of console.h for the actual struct PixelFormat definition, > and on implicitly dragging in a header defining NULL. > > Signed-off-by: Peter Maydell > --- > I noticed this because I had an out of tree file which included > ui/console.h before qemu-common.h and it didn't compile. But mutual > include loops are a bad idea anyway IMHO. > > include/ui/qemu-pixman.h | 2 +- > ui/qemu-pixman.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) CC ui/curses.o In file included from ui/spice-core.c:40:0: /home/stefanha/qemu/include/ui/spice-display.h:93:5: error: unknown type name ‘QEMUCursor’ Stefan