From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism.
Date: Fri, 18 Jan 2013 16:19:02 +0100 [thread overview]
Message-ID: <20130118151902.GA6087@irqsave.net> (raw)
In-Reply-To: <50F879E1.2060507@redhat.com>
> Hmm, adler32() is basically a weak hashing mechanism; are you sure you
> won't have any false collisions? Furthermore, how does this compare
> with the series for adding deduplication, which uses much
> stronger/longer hashes, but where those take more time to compute? Is
> there any way you can share efforts between the two series?
I agree that using sha256 would be a better option as it will not be called
frequently.
However the call to gnutls is a one liner so it's likely not shareable.
The configure would need to be modified to require gnutls and It likely not
factorisable either.
I'll change the code to use sha256.
Regards
Benoît
>
> > + /* get the index of the first successfull read */
>
> s/successfull/successful/ (several times in this patch)
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
next prev parent reply other threads:[~2013-01-18 15:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 15:51 [Qemu-devel] [RFC V6 00/11] Quorum block filter Benoît Canet
2013-01-17 15:51 ` [Qemu-devel] [RFC V6 01/11] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB Benoît Canet
2013-01-17 15:51 ` [Qemu-devel] [RFC V6 02/11] quorum: Create BDRVQuorumState and BlkDriver and do init Benoît Canet
2013-01-17 15:51 ` [Qemu-devel] [RFC V6 03/11] quorum: Add quorum_open() and quorum_close() Benoît Canet
2013-01-17 22:13 ` Eric Blake
2013-01-17 15:51 ` [Qemu-devel] [RFC V6 04/11] quorum: Add quorum_aio_writev and its dependencies Benoît Canet
2013-01-17 15:51 ` [Qemu-devel] [RFC V6 05/11] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify Benoît Canet
2013-01-17 15:51 ` [Qemu-devel] [RFC V6 06/11] quorum: Add quorum_aio_readv Benoît Canet
2013-01-17 15:51 ` [Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism Benoît Canet
2013-01-17 22:23 ` Eric Blake
2013-01-18 15:19 ` Benoît Canet [this message]
2013-01-17 15:51 ` [Qemu-devel] [RFC V6 08/11] quorum: Add quorum_getlength() Benoît Canet
2013-01-17 15:51 ` [Qemu-devel] [RFC V6 09/11] quorum: Add quorum_invalidate_cache() Benoît Canet
2013-01-17 15:51 ` [Qemu-devel] [RFC V6 10/11] quorum: Add quorum_co_is_allocated Benoît Canet
2013-01-17 15:51 ` [Qemu-devel] [RFC V6 11/11] quorum: Add quorum_co_flush() Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118151902.GA6087@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).