From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, vrozenfe@redhat.com
Subject: Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting
Date: Fri, 18 Jan 2013 16:59:37 +0100 [thread overview]
Message-ID: <20130118155937.GB21114@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1358437614-14968-1-git-send-email-stefanha@redhat.com>
On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote:
> The viostor virtio-blk driver for Windows does not use the
> VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK
> bit.
>
> The viostor driver refreshes the virtio-pci status byte sometimes while
> the guest is running. We misinterpret 0x4 (VIRTIO_CONFIG_S_DRIVER_OK)
> as an indication that virtio-blk-data-plane should be stopped since 0x2
> (VIRTIO_CONFIG_S_DRIVER) is missing. The result is that the device
> becomes unresponsive.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/virtio-blk.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
next prev parent reply other threads:[~2013-01-18 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 15:46 [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting Stefan Hajnoczi
2013-01-17 15:59 ` Michael S. Tsirkin
2013-01-17 16:59 ` Stefan Hajnoczi
2013-01-18 15:59 ` Stefan Hajnoczi [this message]
2013-01-19 7:59 ` Vadim Rozenfeld
2013-01-21 9:36 ` Stefan Hajnoczi
2013-01-21 10:05 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118155937.GB21114@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).