Re: [Qemu-devel] [PATCH v2] block: do_commit() does not pass along error messages for all errors

[Jeff Cody <jcody@redhat.com>]

On Fri, Jan 18, 2013 at 06:11:25PM +0100, Markus Armbruster wrote:
> Jeff Cody <jcody@redhat.com> writes:
> 
> > The non-live bdrv_commit() function may return one of the following
> > errors: -ENOTSUP, -EBUSY, -EACCES, -EIO.  The only error that is
> > checked in the HMP handler is -EBUSY, so the monitor command 'commit'
> > silently fails for all error cases other than 'Device is in use'.
> > Return error using monitor_printf() and strerror(), and covert existing
> 
> s/covert/convert/
> 
> Suggest "Report error".
> 
> In the same vein, subject could be
> 
>     block: Monitor command commit neglects to report some errors
> 
> > qerror_report() calls in do_commit() to use monitor_printf().
> 
> Patch looks good to me.

Thanks - I went ahead and submitted a v3 with the proposed commit
message changes.

Thanks,
Jeff