From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51719)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1TwG30-0008Rh-BE
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 12:48:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1TwG2t-0000ur-4B
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 12:48:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48854)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1TwG2s-0000uZ-TB
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 12:48:03 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0IHm2Px021711
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 18 Jan 2013 12:48:02 -0500
Date: Fri, 18 Jan 2013 12:47:59 -0500
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20130118174759.GA11533@localhost.localdomain>
References: <fb2d492bd6d672ee8d231c18492e8b56f222c719.1358520591.git.jcody@redhat.com>
	<87libqquv6.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87libqquv6.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH v2] block: do_commit() does not pass along
 error messages for all errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com

On Fri, Jan 18, 2013 at 06:11:25PM +0100, Markus Armbruster wrote:
> Jeff Cody <jcody@redhat.com> writes:
> 
> > The non-live bdrv_commit() function may return one of the following
> > errors: -ENOTSUP, -EBUSY, -EACCES, -EIO.  The only error that is
> > checked in the HMP handler is -EBUSY, so the monitor command 'commit'
> > silently fails for all error cases other than 'Device is in use'.
> > Return error using monitor_printf() and strerror(), and covert existing
> 
> s/covert/convert/
> 
> Suggest "Report error".
> 
> In the same vein, subject could be
> 
>     block: Monitor command commit neglects to report some errors
> 
> > qerror_report() calls in do_commit() to use monitor_printf().
> 
> Patch looks good to me.

Thanks - I went ahead and submitted a v3 with the proposed commit
message changes.

Thanks,
Jeff