From: Marcelo Tosatti <mtosatti@redhat.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] define qemukvm-1.2 machine type
Date: Fri, 18 Jan 2013 17:50:45 -0200 [thread overview]
Message-ID: <20130118195045.GD9449@amt.cnet> (raw)
In-Reply-To: <50F98084.4000200@redhat.com>
On Fri, Jan 18, 2013 at 11:04:04AM -0600, Cole Robinson wrote:
> >> Thanks for the analysis Paolo, here's the final patch I used:
> >>
> >> http://pkgs.fedoraproject.org/cgit/qemu.git/tree/0004-Fix-migration-compat-with-qemu-kvm.patch
> >>
> >> Thanks,
> >> Cole
> >
> > Cole,
> >
> > version_id and minimum_version_id should be changed to 2, as the comment
> > indicates.
Problem is it uses acpi_load_old, when reading from qemu-kvm 1.2 (which
advertises format as V2), which reads 4*16 bits (instead of 16 bits)
for en/sts fields. So it can corrupt incoming migration data.
> But won't that mean we have to carry that patch forever, and while we carry
> that patch we can never migrate from Fedora qemu to an upstream qemu instance?
> I'd like to avoid carrying any incompatibility forward, if possible.
No useful ideas :(
prev parent reply other threads:[~2013-01-18 19:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 22:39 [Qemu-devel] [PATCH] define qemukvm-1.2 machine type Marcelo Tosatti
2012-12-13 8:35 ` Paolo Bonzini
2012-12-13 20:29 ` Marcelo Tosatti
2012-12-13 21:25 ` Eduardo Habkost
2012-12-13 21:35 ` Anthony Liguori
2012-12-13 21:41 ` Eduardo Habkost
2012-12-14 7:54 ` Paolo Bonzini
2012-12-14 13:29 ` Anthony Liguori
2012-12-14 13:46 ` Paolo Bonzini
2012-12-13 21:15 ` Anthony Liguori
2013-01-15 3:45 ` Cole Robinson
2013-01-15 16:29 ` Paolo Bonzini
2013-01-16 23:17 ` Cole Robinson
2013-01-18 12:12 ` Marcelo Tosatti
2013-01-18 17:04 ` Cole Robinson
2013-01-18 17:34 ` Paolo Bonzini
2013-01-18 20:09 ` Marcelo Tosatti
2013-01-19 14:17 ` Paolo Bonzini
2013-01-18 19:50 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118195045.GD9449@amt.cnet \
--to=mtosatti@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=crobinso@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).