From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwIH2-0004Cr-0w for qemu-devel@nongnu.org; Fri, 18 Jan 2013 15:10:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwIH0-0003rx-Oo for qemu-devel@nongnu.org; Fri, 18 Jan 2013 15:10:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwIH0-0003qp-G4 for qemu-devel@nongnu.org; Fri, 18 Jan 2013 15:10:46 -0500 Date: Fri, 18 Jan 2013 18:09:27 -0200 From: Marcelo Tosatti Message-ID: <20130118200927.GA12992@amt.cnet> References: <50F98084.4000200@redhat.com> <1217640499.8205475.1358530497031.JavaMail.root@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1217640499.8205475.1358530497031.JavaMail.root@redhat.com> Subject: Re: [Qemu-devel] [PATCH] define qemukvm-1.2 machine type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Anthony Liguori , qemu-devel@nongnu.org, Cole Robinson On Fri, Jan 18, 2013 at 12:34:57PM -0500, Paolo Bonzini wrote: > > > version_id and minimum_version_id should be changed to 2, as the > > > comment indicates. > > > > But won't that mean we have to carry that patch forever, and while we carry > > that patch we can never migrate from Fedora qemu to an upstream qemu instance? > > I'd like to avoid carrying any incompatibility forward, if possible. > > To some extent you have to choose between backwards- and forwards- > compatibility. But I think that you can achieve what you want > by leaving version_id to 3, while setting minimum_version_id to 2. > > Paolo What about "Problem is it uses acpi_load_old, when reading from qemu-kvm 1.2 (which advertises format as V2), which reads 4*16 bits (instead of 16 bits) for en/sts fields. So it can corrupt incoming migration data."