From: Amos Kong <akong@redhat.com>
To: mst@redhat.com
Cc: rusty@rustcorp.com.au, stefanha@redhat.com,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [QEMU PATCH v4 1/3] virtio-net: remove layout assumptions for ctrl vq
Date: Sat, 19 Jan 2013 10:08:54 +0800 [thread overview]
Message-ID: <20130119020854.GA11286@t430s.redhat.com> (raw)
In-Reply-To: <1358560468-10865-2-git-send-email-akong@redhat.com>
On Sat, Jan 19, 2013 at 09:54:26AM +0800, akong@redhat.com wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
>
> Virtio-net code makes assumption about virtqueue descriptor layout
> (e.g. sg[0] is the header, sg[1] is the data buffer).
>
> This patch makes code not rely on the layout of descriptors.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> hw/virtio-net.c | 128 ++++++++++++++++++++++++++++++++------------------------
> 1 file changed, 74 insertions(+), 54 deletions(-)
Had tested this patch with following scenarios:
VIRTIO_NET_CTRL_RX_MODE
1) ip link eth0 promisc on/off
2) ip link set eth0 allmulticast on/off
3) ip link set eth0 multicast on/off
VIRTIO_NET_CTRL_MAC
4) ifconfig eth0 hw ether 52:54:00:12:34:57
5) ping guest after joined guest into multicast
group (225.0.0.1 ~ 225.0.0.10)
VIRTIO_NET_CTRL_VLAN
6) vconfig add eth0 2; vconfig rem eth0.2
next prev parent reply other threads:[~2013-01-19 2:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 1:54 [Qemu-devel] [QEMU PATCH v4 0/3] virtio-net: fix of ctrl commands akong
2013-01-19 1:54 ` [Qemu-devel] [QEMU PATCH v4 1/3] virtio-net: remove layout assumptions for ctrl vq akong
2013-01-19 2:08 ` Amos Kong [this message]
2013-01-19 1:54 ` [Qemu-devel] [QEMU PATCH v4 2/3] virtio-net: introduce a new macaddr control akong
2013-01-19 1:54 ` [Qemu-devel] [QEMU PATCH v4 3/3] virtio-net: rename ctrl rx commands akong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130119020854.GA11286@t430s.redhat.com \
--to=akong@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).