From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vrozenfe@redhat.com>) id 1TwU2F-0006ll-Q1
	for qemu-devel@nongnu.org; Sat, 19 Jan 2013 03:44:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vrozenfe@redhat.com>) id 1TwU2E-0002DG-FG
	for qemu-devel@nongnu.org; Sat, 19 Jan 2013 03:44:19 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45439)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vrozenfe@redhat.com>) id 1TwTNr-0002H5-EH
	for qemu-devel@nongnu.org; Sat, 19 Jan 2013 03:02:35 -0500
From: Vadim Rozenfeld <vrozenfe@redhat.com>
Date: Sat, 19 Jan 2013 09:59:57 +0200
References: <1358437614-14968-1-git-send-email-stefanha@redhat.com>
	<20130118155937.GB21114@stefanha-thinkpad.redhat.com>
In-Reply-To: <20130118155937.GB21114@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201301190959.57902.vrozenfe@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci
	status bit setting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On Friday, January 18, 2013 05:59:37 PM Stefan Hajnoczi wrote:
> On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote:
> > The viostor virtio-blk driver for Windows does not use the
> > VIRTIO_CONFIG_S_DRIVER bit.  It only sets the VIRTIO_CONFIG_S_DRIVER_OK
> > bit.
Will be added in the next build.
Thank you,
Vadim.
> > 
> > The viostor driver refreshes the virtio-pci status byte sometimes while
> > the guest is running.  We misinterpret 0x4 (VIRTIO_CONFIG_S_DRIVER_OK)
> > as an indication that virtio-blk-data-plane should be stopped since 0x2
> > (VIRTIO_CONFIG_S_DRIVER) is missing.  The result is that the device
> > becomes unresponsive.
> > 
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > 
> >  hw/virtio-blk.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Applied to my block tree:
> https://github.com/stefanha/qemu/commits/block
> 
> Stefan