From: David Miller <davem@davemloft.net>
To: akong@redhat.com
Cc: kvm@vger.kernel.org, mst@redhat.com, netdev@vger.kernel.org,
rusty@rustcorp.com.au, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH v4 2/3] net: split eth_mac_addr for better error handling
Date: Sun, 20 Jan 2013 23:14:32 -0500 (EST) [thread overview]
Message-ID: <20130120.231432.1625470984232658368.davem@davemloft.net> (raw)
In-Reply-To: <1358649789-2338-3-git-send-email-akong@redhat.com>
From: akong@redhat.com
Date: Sun, 20 Jan 2013 10:43:08 +0800
> From: Stefan Hajnoczi <stefanha@gmail.com>
>
> When we set mac address, software mac address in system and hardware mac
> address all need to be updated. Current eth_mac_addr() doesn't allow
> callers to implement error handling nicely.
>
> This patch split eth_mac_addr() to prepare part and real commit part,
> then we can prepare first, and try to change hardware address, then do
> the real commit if hardware address is set successfully.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
> Signed-off-by: Amos Kong <akong@redhat.com>
This patch doesn't apply to net-next.
next prev parent reply other threads:[~2013-01-21 4:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 2:43 [Qemu-devel] [PATCH v4 0/3] make mac programming for virtio net more robust akong
2013-01-20 2:43 ` [Qemu-devel] [PATCH v4 1/3] move virtnet_send_command() above virtnet_set_mac_address() akong
2013-01-20 2:43 ` [Qemu-devel] [PATCH v4 2/3] net: split eth_mac_addr for better error handling akong
2013-01-21 4:14 ` David Miller [this message]
2013-01-20 2:43 ` [Qemu-devel] [PATCH v4 3/3] virtio-net: introduce a new control to set macaddr akong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130120.231432.1625470984232658368.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akong@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).