From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwxzE-0004Fq-Ef for qemu-devel@nongnu.org; Sun, 20 Jan 2013 11:43:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwxzD-0000kF-0r for qemu-devel@nongnu.org; Sun, 20 Jan 2013 11:43:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwxzC-0000ju-P5 for qemu-devel@nongnu.org; Sun, 20 Jan 2013 11:43:10 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0KGh8Df006422 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 20 Jan 2013 11:43:09 -0500 Date: Sun, 20 Jan 2013 18:30:04 +0200 From: Alon Levy Message-ID: <20130120163004.GA11499@garlic.redhat.com> References: <50F5738A.7080904@redhat.com> <1358359170-19271-1-git-send-email-alevy@redhat.com> <50F7F662.4000907@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50F7F662.4000907@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Thu, Jan 17, 2013 at 02:02:26PM +0100, Gerd Hoffmann wrote: > On 01/16/13 18:59, Alon Levy wrote: > > Regarding orientation setting in windows 7 64 guest: > > Desktop, right click->Screen resolution > > - You can choose Orientation: Landscape, Portrait, Landscape (flipped), Portrait (flipped) > > - You can choose Resolution > > - You can click "Advanced Settings", then "List All Modes" at the bottom, you get all the modes (i.e. four of each resolution, one for each orientation) > > Ah, ok. The driver seems to handle portrait and swap x+y when creating > a displaysurface. At least I get a 600x800 display upright. > > I can't see a difference between Landscape + Landscape (flipped). > Likewise Portrait + Portrait (flipped). Is there any? I can't actually get the "(flipped)" modes (both portrait and landscape) to work, I get an error message "Unable to save display settings". How did you manage to get them to work? which driver, qemu command line, qemu version did you use? > > > There are two changes after applying the "change rom size to 8192" patch: > > - there is no longer an Orientation option > > - the modes listed under "List All Modes" reduce as expected > > Ok, so we loose the Portrait mode. > > > Changes to the second patch: > > - no orientations except the normal > > Keeping orientation 0+1 (and dropping the flipped 2+3 versions) should > make the mode list small enougth that it fits while maintaining support > for the portrait mode. That's what I'm going to send. > > I think it would also be good to fix the driver to ignore everything with or > > How about that? > > > - hard code 8192 bytes rom size > > - assert if the required size is larger > > Good. > > cheers, > Gerd > >