From: Paul Brook <paul@codesourcery.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Crosthwaite <peter.crosthwaite@petalogix.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Mark Langsdorf <mark.langsdorf@calxeda.com>,
qemu-ppc@nongnu.org, Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
Blue Swirl <blauwirbel@gmail.com>,
Max Filippov <jcmvbkbc@gmail.com>,
"Vassili Karpov (malc)" <av1474@comtv.ru>,
Paolo Bonzini <pbonzini@redhat.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] Annotate questionable fallthroughs
Date: Sun, 20 Jan 2013 18:32:14 +0000 [thread overview]
Message-ID: <201301201832.15780.paul@codesourcery.com> (raw)
In-Reply-To: <CAFEAcA8o5pnr-VbEAR0WqFvNC5EFvuh1wyAAkyAKqqGYRxp15g@mail.gmail.com>
> I don't think there's much point adding tons of "XXX" comments
> when a bunch of these aren't actually wrong code. If you want to fix
> this I think a better approach would be more focused patches aimed
> at adding 'break;' or "/* fallthrough */" based on actual human
> examination of the surrounding code.
I agree. I encourage annotation of intentional fall through, but blindly
pasting the output of an automated tool is liable to cause more harm than
good.
IMO running code analysis tools is easy. It's only when you take the time to
manually inspect and fix the code that this really becomes valuable.
Paul
next prev parent reply other threads:[~2013-01-20 18:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 15:54 [Qemu-devel] [PATCH] Annotate questionable fallthroughs Blue Swirl
2013-01-20 16:56 ` Peter Maydell
2013-01-20 17:26 ` Blue Swirl
2013-01-20 17:38 ` Andreas Färber
2013-01-20 18:10 ` Peter Maydell
2013-01-20 18:32 ` Paul Brook [this message]
2013-01-21 10:36 ` Markus Armbruster
2013-01-21 8:58 ` Kevin Wolf
2013-01-21 13:11 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301201832.15780.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=av1474@comtv.ru \
--cc=blauwirbel@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jcmvbkbc@gmail.com \
--cc=kwolf@redhat.com \
--cc=mark.langsdorf@calxeda.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).