From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50206)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1Twzh2-0007Hg-CN
	for qemu-devel@nongnu.org; Sun, 20 Jan 2013 13:32:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1Twzh0-00029Z-4Y
	for qemu-devel@nongnu.org; Sun, 20 Jan 2013 13:32:32 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Sun, 20 Jan 2013 18:32:14 +0000
References: <19952e84d566d9309b15fe205db6b166f4234c33.1358697255.git.blauwirbel@gmail.com>
	<CAFEAcA8o5pnr-VbEAR0WqFvNC5EFvuh1wyAAkyAKqqGYRxp15g@mail.gmail.com>
In-Reply-To: <CAFEAcA8o5pnr-VbEAR0WqFvNC5EFvuh1wyAAkyAKqqGYRxp15g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-ID: <201301201832.15780.paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Annotate questionable fallthroughs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Crosthwaite <peter.crosthwaite@petalogix.com>, Anthony Liguori <aliguori@us.ibm.com>, Mark Langsdorf <mark.langsdorf@calxeda.com>, qemu-ppc@nongnu.org, Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, "Vassili
	Karpov (malc)" <av1474@comtv.ru>, Paolo Bonzini <pbonzini@redhat.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

> I don't think there's much point adding tons of "XXX" comments
> when a bunch of these aren't actually wrong code. If you want to fix
> this I think a better approach would be more focused patches aimed
> at adding 'break;' or "/* fallthrough */" based on actual human
> examination of the surrounding code.

I agree.   I encourage annotation of intentional fall through, but blindly 
pasting the output of an automated tool is liable to cause more harm than 
good.

IMO running code analysis tools is easy.  It's only when you take the time to 
manually inspect and fix the code that this really becomes valuable.

Paul