From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxFyx-0000kR-0I for qemu-devel@nongnu.org; Mon, 21 Jan 2013 06:56:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TxFyv-0005EP-Pi for qemu-devel@nongnu.org; Mon, 21 Jan 2013 06:56:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxFyv-0005EA-ID for qemu-devel@nongnu.org; Mon, 21 Jan 2013 06:56:05 -0500 Date: Mon, 21 Jan 2013 09:56:08 -0200 From: Luiz Capitulino Message-ID: <20130121095608.196e8e15@doriath.home> In-Reply-To: <50F9A9DC.2000905@redhat.com> References: <1358537372-27320-1-git-send-email-lcapitulino@redhat.com> <1358537372-27320-4-git-send-email-lcapitulino@redhat.com> <50F9A9DC.2000905@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] docs: document virtio-balloon stats List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: mdroth@linux.vnet.ibm.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, dietmar@proxmox.com, agl@us.ibm.com On Fri, 18 Jan 2013 13:00:28 -0700 Eric Blake wrote: > On 01/18/2013 12:29 PM, Luiz Capitulino wrote: > > Signed-off-by: Luiz Capitulino > > --- > > docs/virtio-balloon-stats.txt | 102 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 102 insertions(+) > > create mode 100644 docs/virtio-balloon-stats.txt > > > > > + > > + o A key named 'stats', containing all avaiable stats. If the guest > > s/avaiable/available/ OK. > > + doesn't support a particular stat, its value will be -1. Currently, > > + the following stats are supported: > > + > > + - stat-swap-in > > + - stat-swap-out > > + - stat-major-faults > > + - stat-minor-faults > > + - stat-free-memory > > + - stat-total-memory > > + > > + o A key named last-update, which contains the last stats update > > + timestamp in seconds > > Is it worth mentioning that this is a timestamp relative to the Unix > epoch? For that matter, does it even matter what the timestamp is > relative to, or just that it increases when a new poll completes? Yes, I think this field is only important to calculate the delta between updates. > Is it > worth mentioning that the timestamp is computed by the host (that is, a > broken guest can't fake the timestamp, even if it can provide bogus data > for all the stats)? I can mention that. > > + > > + - As noted above, if a guest doesn't support a particular stat it > > + will always be -1. However, it's also possible that a guest couldn't > > + temporarily update one or even all stats. If this happens, just wait > > s/couldn't temporarily/temporarily couldn't/ OK. > > + > > +Here are a few examples. The virtio-balloon device is assumed to be in the > > +'/machine/peripheral-anon/device[1]' QOM path. > > Is this QOM path stable, or can it change depending on target > architecture and/or command-line arguments used to install the guest? I think it can change. > It might be worth showing which command line arguments set up this > particular QOM path. Will do.