From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39019)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TxECa-0006yD-1J
	for qemu-devel@nongnu.org; Mon, 21 Jan 2013 05:02:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TxECX-0007cs-DH
	for qemu-devel@nongnu.org; Mon, 21 Jan 2013 05:02:03 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53857)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TxECX-0007cU-6I
	for qemu-devel@nongnu.org; Mon, 21 Jan 2013 05:02:01 -0500
Date: Mon, 21 Jan 2013 12:05:16 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130121100516.GA2488@redhat.com>
References: <1358437614-14968-1-git-send-email-stefanha@redhat.com>
	<20130118155937.GB21114@stefanha-thinkpad.redhat.com>
	<201301190959.57902.vrozenfe@redhat.com>
	<20130121093618.GB8514@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130121093618.GB8514@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci
 status bit setting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Vadim Rozenfeld <vrozenfe@redhat.com>, qemu-devel@nongnu.org

On Mon, Jan 21, 2013 at 10:36:18AM +0100, Stefan Hajnoczi wrote:
> On Sat, Jan 19, 2013 at 09:59:57AM +0200, Vadim Rozenfeld wrote:
> > On Friday, January 18, 2013 05:59:37 PM Stefan Hajnoczi wrote:
> > > On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote:
> > > > The viostor virtio-blk driver for Windows does not use the
> > > > VIRTIO_CONFIG_S_DRIVER bit.  It only sets the VIRTIO_CONFIG_S_DRIVER_OK
> > > > bit.
> > Will be added in the next build.
> 
> Nice, thanks.  For compatibility with existing viostor drivers QEMU will
> carry this patch.
> 
> Stefan

I still think it's wrong: when DRIVER_OK is cleared you should stop
device I think even if DRIVER is set.
This patch keeps dataplane running if DRIVER is set.