From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, Alberto Garcia <agarcia@igalia.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] hw/tpci200: Fix compiler warning (redefined symbol with MinGW)
Date: Mon, 21 Jan 2013 11:39:22 +0100 [thread overview]
Message-ID: <20130121103922.GA9472@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1358750991-18501-1-git-send-email-sw@weilnetz.de>
On Mon, Jan 21, 2013 at 07:49:51AM +0100, Stefan Weil wrote:
> STATUS_TIMEOUT is defined in winnt.h:
>
> CC hw/tpci200.o
> hw/tpci200.c:34:0:
> warning: "STATUS_TIMEOUT" redefined [enabled by default]
> /usr/lib/gcc/x86_64-w64-mingw32/4.6/../../../../x86_64-w64-mingw32/include/winnt.h:1036:0:
> note: this is the location of the previous definition
>
> Use STATUS_TIME instead of STATUS_TIMEOUT as suggested by Alberto Garcia.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> v1: Add QEMU_PREFIX (http://patchwork.ozlabs.org/patch/212348/)
> v2: Use STATUS_TIME
>
> Like v1, this patch fixes a warning for MinGW.
> We could also mix v1 and v2.
>
> Please commit one of those variants to git master.
>
> Regards,
> Stefan W.
>
>
> hw/tpci200.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
prev parent reply other threads:[~2013-01-21 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 6:49 [Qemu-devel] [PATCH v2] hw/tpci200: Fix compiler warning (redefined symbol with MinGW) Stefan Weil
2013-01-21 10:39 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130121103922.GA9472@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=agarcia@igalia.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).