From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51972)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <grant.likely@secretlab.ca>) id 1TxHAY-0000pL-IL
	for qemu-devel@nongnu.org; Mon, 21 Jan 2013 08:12:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <grant.likely@secretlab.ca>) id 1TxHAT-0000WS-DE
	for qemu-devel@nongnu.org; Mon, 21 Jan 2013 08:12:10 -0500
Received: from mail-ie0-f171.google.com ([209.85.223.171]:63916)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <grant.likely@secretlab.ca>) id 1TxHAT-0000WJ-8d
	for qemu-devel@nongnu.org; Mon, 21 Jan 2013 08:12:05 -0500
Received: by mail-ie0-f171.google.com with SMTP id 9so5904486iec.16
	for <qemu-devel@nongnu.org>; Mon, 21 Jan 2013 05:12:04 -0800 (PST)
Sender: Grant Likely <glikely@secretlab.ca>
From: Grant Likely <grant.likely@secretlab.ca>
In-Reply-To: <CAFEAcA9tQvtU0yUrR6DPAMykL0iS258ZzWcgNGusiBmdWkX2TA@mail.gmail.com>
References: <1358634492-22627-1-git-send-email-grant.likely@secretlab.ca>
	<1358634492-22627-4-git-send-email-grant.likely@secretlab.ca>
	<CAFEAcA9tQvtU0yUrR6DPAMykL0iS258ZzWcgNGusiBmdWkX2TA@mail.gmail.com>
Date: Mon, 21 Jan 2013 09:12:02 -0400
Message-Id: <20130121131202.413493E0E73@localhost>
Subject: Re: [Qemu-devel] [PATCH 3/3] net/bitbang_mdio: Use bitbang core for
	smc91c111 network device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>

On Sun, 20 Jan 2013 11:29:32 +0000, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 19 January 2013 22:28, Grant Likely <grant.likely@secretlab.ca> wrote:
> > The smc91c111 device has bitbanged MDIO access, but the model doesn't
> > yet implement it. This patch uses the generalized bitbang MDIO support
> > pulled out of etraxfs Ethernet driver.
> 
> > @@ -44,6 +45,13 @@ typedef struct {
> >      uint8_t int_level;
> >      uint8_t int_mask;
> >      MemoryRegion mmio;
> > +
> > +    /* MDIO bus.  */
> > +    struct qemu_mdio mdio_bus;
> > +    unsigned int phyaddr;
> > +
> > +    /* PHY. */
> > +    struct qemu_phy phy;
> >  } smc91c111_state;
> 
> This surely needs VMState additions so the extra state can be passed
> across migrations. It looks like the MDIO/PHY stuff from the etraxfs code
> doesn't have any kind of state save/restore support, so you probably need
> to first implement that in your new mdio/phy source file, and then refer
> to it here.

Ah, I see. I missed that. I will figure out how to do that and add it to
the next version.

g.