From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxGH9-0008GG-Ab for qemu-devel@nongnu.org; Mon, 21 Jan 2013 07:14:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TxGH8-00020R-2G for qemu-devel@nongnu.org; Mon, 21 Jan 2013 07:14:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxGH7-000206-Q9 for qemu-devel@nongnu.org; Mon, 21 Jan 2013 07:14:53 -0500 Date: Mon, 21 Jan 2013 13:14:49 +0100 From: Igor Mammedov Message-ID: <20130121131449.73883a82@nial.usersys.redhat.com> In-Reply-To: <50FCFEAB.5000600@suse.de> References: <1358435794-8406-1-git-send-email-imammedo@redhat.com> <1358435794-8406-2-git-send-email-imammedo@redhat.com> <50FCFEAB.5000600@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/5] target-i386: print deprecated warning if xlevel < 0x80000000 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?B?RuRyYmVy?= Cc: qemu-devel@nongnu.org, Anthony Liguori , ehabkost@redhat.com On Mon, 21 Jan 2013 09:39:07 +0100 Andreas F=E4rber wrote: > Am 17.01.2013 16:16, schrieb Igor Mammedov: > > Signed-off-by: Igor Mammedov > > Reviewed-by: Eduardo Habkost > > --- > > target-i386/cpu.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > >=20 > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > index 333745b..ce914da 100644 > > --- a/target-i386/cpu.c > > +++ b/target-i386/cpu.c =20 > > @@ -1399,6 +1399,8 @@ static int cpu_x86_parse_featurestr(x86_def_t > > *x86_cpu_def, char *features) goto error; > > } > > if (numvalue < 0x800000 00) { > > + fprintf(stderr, "xlevel value shall always be >=3D > > 0x80000000" > > + ", fixup will be deprecated in future > > versions\n"); numvalue +=3D 0x80000000; > > } > > x86_cpu_def->xlevel =3D numvalue; >=20 > This has been reviewed without objections so far, so I would apply it > for 1.4. Either way you should document this intent for users already: > http://wiki.qemu.org/ChangeLog/1.4 Would be something like this suitable: xlevel argument for -cpu option, currently fix-ups it's value if it's less than 0x80000000. Fix-up will be removed in QEMU 1.6 release and users are expected to provide valid xlevel value or qemu will fail to start. >=20 > We had such discussions before, around removing cpudef support. >=20 > When do you plan to remove this, and being deprecated, shouldn't it > rather read "fixup will be removed in future versions"? ;) > If it fits within 80 chars I can edit it myself. No need for it, I'll fix it and respin series. >=20 > Cheers, > Andreas >=20 Thanks, Igor