From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
qemu-devel@nongnu.org, "1.3.x" <qemu-stable@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-1.4 v2] block/raw-posix: Build fix for O_ASYNC
Date: Fri, 1 Feb 2013 15:11:18 +0100 [thread overview]
Message-ID: <20130201141118.GA29749@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1359643214-26592-1-git-send-email-andreas.faerber@web.de>
On Thu, Jan 31, 2013 at 03:40:14PM +0100, Andreas Färber wrote:
> Commit eeb6b45d48800e96f67ef2a5c80332557fd45ddb (block: raw-posix image
> file reopen) broke the build on OpenIndiana.
>
> illumos has no O_ASYNC. Exclude it from flags to be compared
> and instead assert that it is not set where defined.
>
> Cf. e61ab1da7e98357da47c54d8f893b9bd6ff2f7f9 for qemu-ga.
>
> Cc: qemu-stable@nongnu.org (1.3.x)
> Cc: Jeff Cody <jcody@redhat.com>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> ---
> v1 -> v2:
> * Instead of excluding O_ASYNC from flag comparison only for CONFIG_SOLARIS,
> assert that O_ASYNC is not set if defined. Suggested by Paolo.
>
> block/raw-posix.c | 11 ++++++++++-
> 1 Datei geändert, 10 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
parent reply other threads:[~2013-02-01 14:11 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1359643214-26592-1-git-send-email-andreas.faerber@web.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201141118.GA29749@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=andreas.faerber@web.de \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).