From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54365)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1U1HKv-0000E9-VN
	for qemu-devel@nongnu.org; Fri, 01 Feb 2013 09:11:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1U1HKu-00039g-Kw
	for qemu-devel@nongnu.org; Fri, 01 Feb 2013 09:11:25 -0500
Date: Fri, 1 Feb 2013 15:11:18 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130201141118.GA29749@stefanha-thinkpad.redhat.com>
References: <1359643214-26592-1-git-send-email-andreas.faerber@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1359643214-26592-1-git-send-email-andreas.faerber@web.de>
Subject: Re: [Qemu-devel] [PATCH for-1.4 v2] block/raw-posix: Build fix for
 O_ASYNC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <andreas.faerber@web.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org, "1.3.x" <qemu-stable@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, pbonzini@redhat.com

On Thu, Jan 31, 2013 at 03:40:14PM +0100, Andreas Färber wrote:
> Commit eeb6b45d48800e96f67ef2a5c80332557fd45ddb (block: raw-posix image
> file reopen) broke the build on OpenIndiana.
> 
> illumos has no O_ASYNC. Exclude it from flags to be compared
> and instead assert that it is not set where defined.
> 
> Cf. e61ab1da7e98357da47c54d8f893b9bd6ff2f7f9 for qemu-ga.
> 
> Cc: qemu-stable@nongnu.org (1.3.x)
> Cc: Jeff Cody <jcody@redhat.com>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> ---
>  v1 -> v2:
>  * Instead of excluding O_ASYNC from flag comparison only for CONFIG_SOLARIS,
>    assert that O_ASYNC is not set if defined. Suggested by Paolo.
> 
>  block/raw-posix.c |   11 ++++++++++-
>  1 Datei geändert, 10 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan