* Re: [Qemu-devel] [PATCH for-1.4 v2] block/raw-posix: Build fix for O_ASYNC
[not found] <1359643214-26592-1-git-send-email-andreas.faerber@web.de>
@ 2013-02-01 14:11 ` Stefan Hajnoczi
0 siblings, 0 replies; only message in thread
From: Stefan Hajnoczi @ 2013-02-01 14:11 UTC (permalink / raw)
To: Andreas Färber
Cc: Kevin Wolf, Jeff Cody, qemu-devel, 1.3.x, Stefan Hajnoczi,
pbonzini
On Thu, Jan 31, 2013 at 03:40:14PM +0100, Andreas Färber wrote:
> Commit eeb6b45d48800e96f67ef2a5c80332557fd45ddb (block: raw-posix image
> file reopen) broke the build on OpenIndiana.
>
> illumos has no O_ASYNC. Exclude it from flags to be compared
> and instead assert that it is not set where defined.
>
> Cf. e61ab1da7e98357da47c54d8f893b9bd6ff2f7f9 for qemu-ga.
>
> Cc: qemu-stable@nongnu.org (1.3.x)
> Cc: Jeff Cody <jcody@redhat.com>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> ---
> v1 -> v2:
> * Instead of excluding O_ASYNC from flag comparison only for CONFIG_SOLARIS,
> assert that O_ASYNC is not set if defined. Suggested by Paolo.
>
> block/raw-posix.c | 11 ++++++++++-
> 1 Datei geändert, 10 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] only message in thread