From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60437)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1UBWvP-0005aN-DT
	for qemu-devel@nongnu.org; Fri, 01 Mar 2013 15:51:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1UBWvN-0004XY-2z
	for qemu-devel@nongnu.org; Fri, 01 Mar 2013 15:51:27 -0500
Received: from relay1.mentorg.com ([192.94.38.131]:59911)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1UBWvM-0004X6-TP
	for qemu-devel@nongnu.org; Fri, 01 Mar 2013 15:51:25 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Fri, 1 Mar 2013 20:51:16 +0000
References: <1362158507-19310-1-git-send-email-chouteau@adacore.com>
	<1362158507-19310-4-git-send-email-chouteau@adacore.com>
In-Reply-To: <1362158507-19310-4-git-send-email-chouteau@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-6"
Content-Transfer-Encoding: 7bit
Message-ID: <201303012051.17503.paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] target-arm: Fix VFP register byte
	order in GDB remote
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, afaerber@suse.de

> From GDB Remote Serial Protocol doc:
> 
> "The bytes with the register are transmitted in target byte order."

>          /* Aliases for Q regs.  */
>          nregs += 16;
>          if (reg < nregs) {
> 
> -            stfq_le_p(buf, env->vfp.regs[(reg - 32) * 2]);
> -            stfq_le_p(buf + 8, env->vfp.regs[(reg - 32) * 2 + 1]);
> +            stfq_p(buf, env->vfp.regs[(reg - 32) * 2]);
> +            stfq_p(buf + 8, env->vfp.regs[(reg - 32) * 2 + 1]);

This is wrong. You're still using little-endian ordering of words.

Paul