From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33723)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1UBX2G-0007NG-65
	for qemu-devel@nongnu.org; Fri, 01 Mar 2013 15:58:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1UBX2D-0006Rz-Vt
	for qemu-devel@nongnu.org; Fri, 01 Mar 2013 15:58:32 -0500
Received: from relay1.mentorg.com ([192.94.38.131]:60379)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1UBX2D-0006Rs-Q7
	for qemu-devel@nongnu.org; Fri, 01 Mar 2013 15:58:29 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Fri, 1 Mar 2013 20:58:25 +0000
References: <1362158507-19310-1-git-send-email-chouteau@adacore.com>
	<1362158507-19310-5-git-send-email-chouteau@adacore.com>
In-Reply-To: <1362158507-19310-5-git-send-email-chouteau@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-6"
Content-Transfer-Encoding: 7bit
Message-ID: <201303012058.26277.paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] target-arm: always set endian bits in
	big-endian mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, afaerber@suse.de

> +#ifdef TARGET_WORDS_BIGENDIAN
> +    if (arm_feature(env, ARM_FEATURE_V6)
> +        || arm_feature(env, ARM_FEATURE_V7)) {
> +        /* IE and EE bits stay set for big-endian */
> +        env->cp15.c1_sys |= (1 << 31) | (1 << 25);
> +    }
> +#endif

This is wrong for all the CPUs QEMU crrently supports. SCTLR.IE is defined to 
be zero.

Paul