From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBaD4-0000aj-Ny for qemu-devel@nongnu.org; Fri, 01 Mar 2013 19:21:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UBaD2-0001dq-6H for qemu-devel@nongnu.org; Fri, 01 Mar 2013 19:21:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22431) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBaD1-0001cl-V4 for qemu-devel@nongnu.org; Fri, 01 Mar 2013 19:21:52 -0500 Date: Fri, 1 Mar 2013 21:07:25 -0300 From: Marcelo Tosatti Message-ID: <20130302000725.GB25309@amt.cnet> References: <19fae3171e31ae90c208895d90ad912291936794.1358920534.git.hutao@cn.fujitsu.com> <20130208015028.GC3364@amt.cnet> <20130220081348.GC23246@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130220081348.GC23246@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v12 rebased 2/8] start vm after resetting it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Andrew Jones , Gleb Natapov , kvm list , Jan Kiszka , qemu-devel , "linux-kernel@vger.kernel.org" , Blue Swirl , Sasha Levin , Luiz Capitulino , KAMEZAWA Hiroyuki On Wed, Feb 20, 2013 at 04:13:49PM +0800, Hu Tao wrote: > On Thu, Feb 07, 2013 at 11:50:28PM -0200, Marcelo Tosatti wrote: > > On Wed, Jan 23, 2013 at 03:19:23PM +0800, Hu Tao wrote: > > > From: Wen Congyang > > > > > > The guest should run after resetting it, but it does not run if its > > > old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. > > > > > > We don't set runstate to RUN_STATE_PAUSED when resetting the guest, > > > so the runstate will be changed from RUN_STATE_INTERNAL_ERROR or > > > RUN_STATE_PAUSED to RUN_STATE_RUNNING(not RUN_STATE_PAUSED). > > > > It appears the last hunk will automatically reset state from > > RUN_STATE_INTERNAL_ERROR to RUN_STATE_RUNNING ? > > Yes. > > > > > I suppose the transition table allows, from RUN_STATE_INTERNAL_ERROR: > > > > system_reset > > cont > > > > To resume the machine? > > True. > > I think the purpose of this patch is to always reset and _run_ the guest > by `system_reset', avoiding an additional `cont' following `system_reset'. Unclear why its essential to the feature being proposed?